| Anonymous | Login | Signup for a new account | 2013-05-23 04:21 EDT |
| Main | My View | View Issues | Change Log | Roadmap | Docs |
| Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
| ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
| 0001999 | [Slicer4] Core: Building (CMake, Superbuild) | minor | have not tried | 2012-05-08 18:17 | 2012-08-22 15:26 | ||||
| Reporter | kentwilliams | View Status | public | ||||||
| Assigned To | jcfr | ||||||||
| Priority | normal | Resolution | fixed | ||||||
| Status | resolved | Product Version | |||||||
| Summary | 0001999: Expose DCMTK_DIR to Slicer built-in module | ||||||||
| Description |
It should be possible for build-in module to simply do find_package(DCMTK) See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2012/008677.html [^] |
||||||||
| Additional Information | |||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
|
|
|||||||||
 Relationships |
|
|
Notes |
|
|
(0004258) jcfr (administrator) 2012-05-09 14:13 |
Kent, Would be great if you could check if the following topic fix the problem. See https://github.com/jcfr/Slicer/compare/1999-expose-dcmtk-dir-to-built-in-module [^] From the mailing list - See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2012/008679.html: [^] After checkout out branch [1a] (you can have an idea of the change looking at [1b]), I suggest you to simply use: find_package(DCMTK REQUIRED) Indeed, using CMake 2.8.8 the REQUIRED keyword should be properly considered. See [2] Add a comment on issue [3] with your feedback. Thanks Jc [1a] https://github.com/jcfr/Slicer/tree/1999-expose-dcmtk-dir-to-built-in-module [^] [1b] https://github.com/jcfr/Slicer/compare/1999-expose-dcmtk-dir-to-built-in-module [^] [2] http://cmake.org/gitweb?p=cmake.git;a=commit;h=c91a54d [^] [3] http://www.na-mic.org/Bug/view.php?id=1999 [^] |
|
(0005474) pieper (administrator) 2012-07-31 16:48 |
Can't this be closed now? |
|
(0005716) jcfr (administrator) 2012-08-22 15:26 |
Assuming Slicer has been built with DICOM support ... Calling "find_package(Slicer)", then "include(${Slicer_USE_FILE})" should be sufficient to make DCMTK CMake module available. That said, nothing would prevent you from calling find_package(DCMTK) again since .. DCMTK_DIR is defined within SlicerConfig.cmake See https://github.com/Slicer/Slicer/blob/master/CMake/SlicerConfig.cmake.in#L223 [^] and https://github.com/Slicer/Slicer/blob/master/CMake/SlicerGenerateSlicerConfig.cmake#L100 [^] |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-05-08 18:17 | jcfr | New Issue | |
| 2012-05-08 18:17 | jcfr | Status | new => assigned |
| 2012-05-08 18:17 | jcfr | Assigned To | => jcfr |
| 2012-05-08 18:27 | jcfr | Reporter | jcfr => kentwilliams |
| 2012-05-09 14:11 | jcfr | Target Version | => Slicer 4.2.0 AHM Summer 2012 |
| 2012-05-09 14:13 | jcfr | Note Added: 0004258 | |
| 2012-05-09 14:13 | jcfr | Status | assigned => feedback |
| 2012-07-31 16:48 | pieper | Note Added: 0005474 | |
| 2012-08-22 15:26 | jcfr | Note Added: 0005716 | |
| 2012-08-22 15:26 | jcfr | Status | feedback => resolved |
| 2012-08-22 15:26 | jcfr | Fixed in Version | => Slicer 4.2.0 - Feature freeze Sept 1st 2012 |
| 2012-08-22 15:26 | jcfr | Resolution | open => fixed |
| Mantis 1.1.4[^] Copyright © 2000 - 2008 Mantis Group |  |
