2009 Winter Project Week Compiler Warnings:Slicer3 Graffiti - Revision history

Lorensen: /* Dangerous Code Detected by Warnings */

2009-01-05T19:32:46Z

Dangerous Code Detected by Warnings

Lorensen: /* Key Investigators */

2009-01-04T19:31:19Z

Key Investigators

Lorensen: /* Key Investigators */

2009-01-04T13:50:00Z

Key Investigators

Lorensen at 17:15, 2 January 2009

2009-01-02T17:15:33Z

Lorensen at 18:38, 1 January 2009

2009-01-01T18:38:31Z

Lorensen: /* Dangerous Code Detected by Warnings */

2008-12-29T19:11:56Z

Dangerous Code Detected by Warnings

Lorensen: /* Dangerous Code Detected by Warnings */

2008-12-29T18:29:03Z

Dangerous Code Detected by Warnings

Lorensen: /* Dangerous Code Detected by Warnings */

2008-12-29T18:23:10Z

Dangerous Code Detected by Warnings

Lorensen: /* Dangerous Code Detected by Warnings */

2008-12-29T15:52:25Z

Dangerous Code Detected by Warnings

Lorensen: /* Dangerous Code Detected by Warnings */

2008-12-29T15:29:10Z

Dangerous Code Detected by Warnings

@@ Line 123: / Line 123: @@
 </pre>
 == Dangerous Code Detected by Warnings ==
 {| border="1"
@@ Line 128: / Line 130: @@
 ! Code
 ! Fixed Code
 |-
@@ Line 142: / Line 145: @@
      << this->CursorColor['''1'''] << ","
      << this->CursorColor['''2'''] << "\n";
 |-
+|
@@ Line 159: / Line 164: @@
    angle[7] = (vtkMath::Dot(f,b));
    angle[8] = (vtkMath::Dot(f,c));
 |-
+|
@@ Line 176: / Line 183: @@
        volume++;
+   }
 |-
+|
@@ Line 201: / Line 210: @@
    this->BackgroundLayer = '''backgroundLayer''';
   ...
 |-
+|
@@ Line 210: / Line 221: @@
    //Enable/Disable navigation window
    this->'''EnableDisableNavButton = NULL''';
 |-
+|
@@ Line 221: / Line 234: @@
          '''strcmp(this->GetPassword(),"") == 0)'''
+     {
 |-
+|
@@ Line 228: / Line 243: @@
+|
   sscanf(line, "%*s '''%lg'''", &this->ResidualFWHM);
 |-
+|
@@ Line 235: / Line 252: @@
+|
   '''size_t''' pos = filename.find(".stl");
 |-
+|
 value computed is not used
+|
-  (vtkMimxModPointWidget*) (Self->PointWidget->GetItemAsObject(i))
+  (vtkMimxModPointWidget*)(Self->PointWidget->GetItemAsObject(i))
-      ->AddObserver(vtkCommand::InteractionEvent,Self->PWCallback);
+  ->AddObserver(vtkCommand::InteractionEvent,Self->PWCallback);
+|
- '''('''(vtkMimxModPointWidget*) (Self->PointWidget->GetItemAsObject(i))''')'''
+A tricky one. Can you find it? The compiler did.
 |-
+|
@@ Line 249: / Line 270: @@
+|
   fprintf(stderr,
-   "ERROR: QdecGlmDesign::GenerateContrasts: contrast size '''%d''' != %d\n",
+   "ERROR: QdecGlmDesign contrast size '''%d''' != %d\n",
    contrast.size(), nreg);
+|
   fprintf(stderr,
-   "ERROR: QdecGlmDesign::GenerateContrasts: contrast size '''%ul''' != %d\n",
+   "ERROR: QdecGlmDesign contrast size '''%ul''' != %d\n",
    '''(unsigned long)''' contrast.size(), nreg);
 |-
+|
@@ Line 268: / Line 291: @@
   i = tags.find("=");
   if ( i != std::string::npos)
 |-
 |}

← Older revision		Revision as of 19:31, 4 January 2009
Line 70:		Line 70:

	</div>		</div>
		+
		+	==Status==
		+	All warnings from the gcc4.3 compiler on BillsBasement have been removed except for the optional IGT code. During project Week, I'll work with others that have different nightly build configurations.

	===Additional Data===		===Additional Data===

@@ Line 48: / Line 48: @@
 On December 1, 2008, a clean Slicer3 build using the gcc 4.3 compiler produced 523 warnings in 173 source files. The CXX_FLAGS
 ''-Wall -Wshadow -Wcast-qual'' produced the following warnings:
 * 278: shadowed variables
-** 278: shadowed variables
+* 131: unused variable
-***131: unused variable
+* 29: suggest parentheses around && within ||
-*** 29: suggest parentheses around && within ||
+* 26: comparison between signed and unsigned integer expressions
-*** 26: comparison between signed and unsigned integer expressions
+* 17:  deprecated conversion from string constant to ‘char*’
-*** 17:  deprecated conversion from string constant to ‘char*’
+* 14: defined but not used
-*** 14: defined but not used
+* 13: cast from type ‘const char*’ to type ‘char*’ casts away constness
-*** 13: cast from type ‘const char*’ to type ‘char*’ casts away constness
+* 7: format expects type t argument has type ‘double’
-*** 7: format expects type t argument has type ‘double’
+* 2: zero-length printf format string
 *'''''A'''nalyze''
 A description of each warning, why it is important and how to eliminate it will be provided.
 *'''''I'''mprove''
-All Slicer3 source files with GCC warning defects will be repaired. This is a manual process. For this project, the xemacs ''compile'' module produced a ''*compilation*'' buffer. The ''compile-goto-next-error'' command loaded the defective file and positioned the cursor at the defective line of code. This facilitated the manual process. Still, the warning defect cleansing took approximately 16 hours of hand editing.
+All Slicer3 source files with GCC warning defects will be repaired. This is a manual process. For this project, the xemacs ''compile'' module produced a ''*compilation*'' buffer. The ''compile-goto-next-error'' command loaded the defective file and positioned the cursor at the defective line of code. This facilitated the manual process. Still, the warning defect cleansing took approximately 16 hours of hand editing. Over '''200''' files were edited.
 *'''''C'''ontrol''
 The [http://www.cdash.org/CDash/index.php?project=Slicer3 Slicer3 dashboard] reports the warnings each day. Individuals will receive e-mails when they introduce warnings. Other more drastic measures will be investigated. For example, the GCC compiler flag ''-Werror'' can treat warnings as errors, thus blocking compilation of any files that have defects.

@@ Line 1: / Line 1: @@
 {|
 |[[Image:NAMIC-SLC.jpg|thumb|320px|Return to [[2009_Winter_Project_Week|Project Week Main Page]] ]]
 |[[Image:Slicer3Graffiti.png|thumb|320px]]
 |}

@@ Line 1: / Line 1: @@
 {|
 |[[Image:NAMIC-SLC.jpg|thumb|320px|Return to [[2009_Winter_Project_Week|Project Week Main Page]] ]]
 |}
 __NOTOC__