Projects:ARRA:VTKWidgetsTesting - Revision history

Naucoin: /* Representations */

2010-11-01T21:17:26Z

Representations

Naucoin: /* Widgets */

2010-11-01T21:16:12Z

Widgets

Naucoin at 16:52, 10 August 2010

2010-08-10T16:52:30Z

Naucoin: /* Requested Changes */

2010-08-10T16:49:05Z

Requested Changes

Naucoin at 16:42, 10 August 2010

2010-08-10T16:42:04Z

Naucoin: /* Preliminary Steps */

2010-08-10T16:36:05Z

Preliminary Steps

Naucoin: /* Preliminary Steps */

2010-08-10T16:35:19Z

Preliminary Steps

Naucoin: /* Preliminary Steps */

2010-08-10T16:34:09Z

Preliminary Steps

Naucoin: /* Widgets */

2010-08-09T22:33:15Z

Widgets

Naucoin: /* Widgets */

2010-08-09T22:26:58Z

Widgets

@@ Line 105: / Line 105: @@
 ****'''vtkTextRepresentation'''
 *****no Get macro for TextProperty, but does have a macro for GetTextActor
 ***'''vtkImplicitPlaneRepresentation'''
 **** does it match to vtkImplicitPlaneWidget2?

@@ Line 51: / Line 51: @@
 ****Only uses text actor 2d
 ***'''vtkTextWidget'''
 **'''vtkHoverWidget''' Would like GetWidgetState macro
 ***'''vtkBalloonWidget'''

@@ Line 1: / Line 1: @@
-== Preliminary Steps ==
+== Setting up Testing ==
 Working from the [http://github.com/pieper/SlicerVTK/ Slicer3 VTK56 git repository]. First wave of changes checked in on August 10, 2010.
@@ Line 23: / Line 23: @@
 Then new testing .cxx files were crafted and added to the CMakeLists.txt to use these basic macros to test every call.
-== WORK IN PROGRESS ==
+== Priority Widgets ==
 === Widgets ===

← Older revision		Revision as of 16:49, 10 August 2010
Line 163:		Line 163:
	In general, being able to do unit testing on the widgets, representations and handle representations is still dependent on knowledge of how to set up the widgets in a render window. It would be useful to have more checks on the rendering classes, especially those that will prevent segmentation faults.		In general, being able to do unit testing on the widgets, representations and handle representations is still dependent on knowledge of how to set up the widgets in a render window. It would be useful to have more checks on the rendering classes, especially those that will prevent segmentation faults.

−	* Get macros for widget state	+	Culling through my notes above, a high level summary is:
		+	* Widgets
		+	** Get macros for widget state
		+	** Get macros for handle widgets
		+	** GetXRepresentation defined on the subclasses to return the expected subclass of vtkWidgetRepresentation
		+	** Spline needs an API to start/stop/add points manually
		+	** Balloon needs SetBalloonString
		+	* Representations
		+	** Get macros, (double, double, double) method signatures
		+	** Line - ticks
		+	* Handle Representations
		+	** fixes to allow unit testing

@@ Line 133: / Line 133: @@
 === Handle Representations ===
-Used by the representations, inherit from vtkAbstractWidget: (all of these are seg faulting, need to revisit my top level testing macros to see if I can set up a viewport/active camera)
+Used by the representations, inherit from vtkAbstractWidget: (all of these are seg faulting, need to revisit my top level testing macros to see if I can figure out why, not enabled in the checked in CMakeLists.txt file as of Aug 10/10)
 * '''vtkHandleRepresentation'''
 ** '''vtkAbstractPolygonalHandleRepresentation3D'''
 ***defines Property and SelectedProperty here
-***Highlight is protected in this class, public in the superclass
+***Highlight is protected in this class, public in the superclass  (fixed)
-***LabelText missing Set(double, double, double)
+***LabelText missing Set(double, double, double)  (fixed)
 ***'''vtkPolygonalHandleRepresentation3D'''
 **** in .h file only defines Offset
@@ Line 145: / Line 145: @@
 **** doesn't define Offset though comment at top of .h file mentions it
 **'''vtkSphereHandleRepresentation'''
-***Highlight is protected in this class, public in the superclass
+***Highlight is protected in this class, public in the superclass (fixed)
-***Crashes when test StartWidgetInteraction, in VTK/Rendering/vtkPicker.cxx:241, winSize is declared as int* and not init if there's no RenderWindow, still crashes when test for it, in vtkCoordinate
+***Crashes when test StartWidgetInteraction, in VTK/Rendering/vtkPicker.cxx:241, winSize is declared as int* and not initialised if there's no RenderWindow, still crashes when test for it, in vtkCoordinate
 **'''vtkPointHandleRepresentation2D'''
 *** Property and SelectedProperty might be worthwhile to move up to the HandleRepresentation superclass
-***Highlight is protected in this class, public in the superclass
+***Highlight is protected in this class, public in the superclass  (fixed)
-***SetPointPlacer is protected in this class, public in the superclass (it's not used as the point is constrained to a plane, SetPointPlacer is defined as a macro in the .cxx class)
+***SetPointPlacer is protected in this class, public in the superclass (it's not used as the point is constrained to a plane, SetPointPlacer is defined as a macro in the .cxx class)  (fixed)
 ***Seg faults in GetDisplayPosition while in BuildRepresentation, VTK/Rendering/vtkRenderer.cxx:1363 not checking for null active camera, when check that it's back to crashing like the sphere handle rep, at VTK/Filtering/vtkCoordinate.cxx:202
 **'''vtkPointHandleRepresentation3D'''
 *** valid values of translation mode?
-***Highlight is protected in this class, public in the superclass
+***Highlight is protected in this class, public in the superclass (fixed)
 **'''vtkConstrainedPointHandleRepresentation.h'''
 *** No SetProperty, SetActiveProperty, SetSelectedProperty, have to do Get and then set things on that variable
-***Highlight is protected in this class, public in the superclass
+***Highlight is protected in this class, public in the superclass (fixed)

@@ Line 1: / Line 1: @@
 == Preliminary Steps ==
-Working from the Slicer3 VTK56 git repository.
+Working from the Slicer3 VTK56 git repository. First wave of changes checked in on August 10, 2010.
 First goal is to set up a similar infrastructure as used in Slicer3/Libs/MRML/Testing, which includes a file that defines basic testing macros (Slicer3/TestingMacros.h) that calls methods on super classes and chains macros together as you get down to testing subclasses. The file
@@ Line 19: / Line 19: @@
     EXERCISE_BASIC_HANDLE_REPRESENTATION_METHODS -  test handle representations that inherit from vtkHandleRepresentation (seg faulting)
     EXERCISE_BASIC_ABSTRACT_POLYGONAL_HANDLE_REPRESENTATION3D_METHODS
-test handle representations that in herit from vtkAbstractPolygonalHandleRepresentation3D ()
+test handle representations that in herit from vtkAbstractPolygonalHandleRepresentation3D (Polygonal and Oriented Polygonal 3D)
 Then new testing .cxx files were crafted and added to the CMakeLists.txt to use these basic macros to test every call.

@@ Line 7: / Line 7: @@
 is set up to define:
     EXERCISE_BASIC_OBJECT_METHODS (copied from Slicer, thanks to Luis Ibanez)
-    TEST_SET_GET for various variable types (INT, BOOLEAN, STRING, DOUBLE, VECTOR3, CHAR)
+    TEST_SET_GET for various variable types (INT, BOOLEAN, STRING, DOUBLE, VECTOR3, VECTOR2, CHAR)
     EXERCISE_BASIC_INTERACTOR_OBSERVER_METHODS for the superclass (could be moved/copied to VTK/Rendering/Testing, no tests yet)
-    EXERCISE_BASIC_ABSTRACT_METHODS
+    EXERCISE_BASIC_ABSTRACT_METHODS to test vtkAbstractWidget method
     EXERCISE_BASIC_BORDER_METHODS to test widgets that inherit from vtkBorderWidget (Text)
     EXERCISE_BASIC_HOVER_METHOD to test widgets that inherit from vtkHoverWidget (Balloon)
@@ Line 16: / Line 16: @@
     EXERCISE_BASIC_ANGLE_REPRESENTATION_METHODS to test representations that inherit from the vtkAngleRepresentation superclass
     EXERCISE_BASIC_BORDER_REPRESENTATION_METHODS to test representations that inherit from the vtkBorderRepresentation
 Then new testing .cxx files were crafted and added to the CMakeLists.txt to use these basic macros to test every call.

@@ Line 49: / Line 49: @@
 ***'''vtkBalloonWidget'''
 ****Would like SetBalloonString
-****Failing the basic interactor observer tests
+****Failing the basic interactor observer tests, seg faults on destructor of smart pointer
 ****Problem with changing text on this widget, doesn't update the representation

@@ Line 36: / Line 36: @@
 ***'''vtkSeedWidget'''
 ****Would like Get macros for WidgetState, Defining.
-****Calling CreateNewHandle crashes if HandleRepresentation is null, need to test for that in *vtkSeedRepresentation::GetHandleRepresentation and in vtkSeedWidget::CreateNewHandle. Test currently failing, suggest that a default handle representation is created.
+****Calling CreateNewHandle crashes if HandleRepresentation is null, need to test for that in *vtkSeedRepresentation::GetHandleRepresentation and in vtkSeedWidget::CreateNewHandle.
 ***'''vtkSplineWidget2'''
 ****Would like Get macro for WidgetState