Difference between revisions of "Engineering:TCON 2011"

From NAMIC Wiki
Jump to: navigation, search
Line 25: Line 25:
 
** use cases between move all slices by copying this slices's RAS matrix to the other slice nodes, and linked increment slice that moves the other slices by an incremental distance
 
** use cases between move all slices by copying this slices's RAS matrix to the other slice nodes, and linked increment slice that moves the other slices by an incremental distance
 
** reformat mode and linking. If in compare view mode and change one of multiple reformat slices, the other reformatted slice views will jump to that
 
** reformat mode and linking. If in compare view mode and change one of multiple reformat slices, the other reformatted slice views will jump to that
 +
** proposal: link some mode, so have more granularity than all or none (currently do have a one slice link toggle key)
 +
*** reserve some link states so can by default link certain slices
  
 
==2011-03-10==
 
==2011-03-10==

Revision as of 19:56, 17 March 2011

Home < Engineering:TCON 2011
Back to TCON:Main, Events

2011-03-17

Attendees: Jim, Ron, Marc, Tina, Nicole, Xiaodong, Greg, Dave Partika, Julien Finet

Agenda:

  • Slicer 3.6.3: 64 bit versions, extensions
  • the default location for a lot of slicer things is the user home directory. This should be changed. It causes problems in the SPL.
    • where to put it, how to initiate?
  • saving Slicer 4 mrml scenes as secondary capture (Ron)
    • I would like to be able to save an entire scene as a dicom secondary capture. This would allow to use accessible pacs systems as repositories for slicer scenes
    • is there a way to incorporate thumbnails and descriptions from the new sceneviews?
  • Slicer3 linked controls

Notes:

  • Dave P will build Windows builds of Slicer and extensions (a version without numpy, make a release note) and Steve will upload. Also the darwin, need to match svn version
  • Default location: ask user for not home dir directory if default is not set
  • Secondary capture to interact with PACS
    • tcon before project week with Jim, Nicole, Wendy, Steve to talk about infrastructure
  • Linked controls
    • Scroll wheel and arrows after Steve/Nicole's implementation of the link/orientation flag only scroll the current slice viewer and the other viewers with the same orientation, need more feedback from users/Andrey
    • use cases between move all slices by copying this slices's RAS matrix to the other slice nodes, and linked increment slice that moves the other slices by an incremental distance
    • reformat mode and linking. If in compare view mode and change one of multiple reformat slices, the other reformatted slice views will jump to that
    • proposal: link some mode, so have more granularity than all or none (currently do have a one slice link toggle key)
      • reserve some link states so can by default link certain slices

2011-03-10

Attendees: Jim, Steve, Mark S., Nicole, Tina

Agenda:

  • 3.6.4 release planning discussion [1]
    • In particular, fix for the linked slice views [2] (see also 1003)
    • pan mode resets slice orientation (bug #1117)
    • What steps should be used for testing fixes for these bugs?
      • Are all use cases covered in currently documented behavior?
      • Show hide reformat widget behavior should incorporate the Michal Depa/Steve Pieper modifcations for linked views with reformat widget.
      • What optimizations (delayed updates) are we expected in for situations like compare view?
    • when linked views are in the same location and visible, there are artifacts in the 3d viewer.
  • More flexibility in the names of the results of CLI's. It would be good to have the ability to incorporate:
    • Source volume name
    • Module name
    • some important parameters

Notes:

  • linked slice views: Jim will write up a wiki page describing the expected behaviour, Steve and Nicole will debug
  • CLI names: Jim says "yes"
  • CLI compilation with separated header files: Jim, Steve, Mark to look into this via webex

2011-03-03

Attendees: Steve, Nicole, Jim, Andrey, Suarez, Ron, Stephen A., Daniel H, Dominique B., Xioadong, Greg Sharp, Mark S, Dominik, Hans

Agenda:

  • C++/C wrapping of modules
    • Hans and Greg figured out what was going wrong. In BRAINS tools they did a trick to get around Bill's trick. It takes 8 minutes to build BRAINSfit, to break it down into smaller compilation units and test it using ITK testing framework. It has a thin wrapper around program to add comparator functions. BRAINSfit is a small 3 line wrapper around BRAINS fit primary that takes argc and argv and includes generated header file. You can't include CLP header file in both compilation units since functions are defined in header file. See error at link time. If you put the right ifdef compiling for slicer and module description is defined you can make it work. Hans would like to see the CLP broken apart into a compile until and a header unit. Jim: harder to build and link - but is done through macros. Could have a test before include CLP.h. Hans: wants to be able to include the .h file in every file. Change: now would have to write a programCLP.h and programCLP.cxx.
    • definitely needs to be done in Slicer4, tbd in Slicer3 (Hans using Slicer3 in his class).
      • the add executable, add library lines macros would need to be touched, need to link new object file
      • before when build both a shared and a command line module it would have to rebuild all the itk stuff twice, Casey made the change to not require it
      • Steve: came up wrt diffusion modules because they're using vtk nrrd readers that don't know about shared memory pointers
      • Hans: was building itk files three times for exec, lib, testing
    • Jim will take a look at what breaks when try to split it out, code generation is easy, the add_executable will be a bit tricky
    • Hans: suggests adding the .cxx to the GenerateCLP macro that defines the .h, to use in the CMakeLists. Hans will do the changes to all the execution modules that need to be changed once the infrastructure is changed (or not).
    • One BRAINSfit test failing: any multi threaded mutual information code is suspect to the bug that they found. Quick fix: restrict to one thread, huge slow down (2-4x). Bug is in the Mattes mutual information optimize metric (?) in the registration framework for certain number of threads (4,7, etc). Stephen A will look at it after March 9.
  • Annotation module widget priority for ROI nodes
    • Ron, Daniel agrees to put it as higher than the bidimensional widget
    • ROI widget is in the critical path for the volume rendering module, as well as others
    • Reformat widget to priority list? will require taking something out. Will is working on a new widget, wait on that. Andrey says the reformat widget will be useful in crop volume as well. General Slicer4 widget (was integrated in the 3d viewer in Slicer3). Nicole is taking on the integration of the vtk widgets.
  • Contributing modules to Slicer4 (policy review)
    • by default new modules should got to an external repository (NITRC, external module) and remain there for a while until whole module goes into Slicer4 if it's determined to be core functionality
    • Slicer4 core to remail lean, but external modules to be first class citizens.
    • Documentation requirements, building and testing on the factory machine every night.
    • If a new module fails it shouldn't break Slicer4 building or running
    • Timeline on extension mechanism in Slicer4?
      • Steve wanted to get the base nightly builds working first, but need to get the extensions built nightly asap
      • new feature in next release of cdash and cmake, ctest upload command to upload binaries, can get a list of uploads from dashboard
      • harvest the information from the cdash dashboard and make it available to the extension manager rather than have the extension manager communicate directly with the (sometimes slow) dashboards. Only let uploads come from factory machines. Use VMs to run test code.
      • Steve will be the gatekeeper to allow code to be built and tested on the factory for now
        • flag for if it gets redistributed, critical/non critical build
        • allow to build locally but submit to main slicer dashboard (no code upload), already supported via Experimental
    • Greg: wants to be able to build a bug fixed version of an extension for an old release (limited support for it)

2011-02-10

Attendees: Jim, Mark, Tina, Nicole, Dan

Agenda:

2011-02-03

Attendees: Suares, Dominik, Kilian, Dominique, Nicole, Daniel, Stephen, Tina, Xiaodong

Agenda:

2011-01-27

No tcon today.

2011-01-20

Attendees: Xiaodong, Wendy, Tina, Mark, Nicole, Dominik, Daniel,

Agenda

2011-01-06

Attendees: Steve, Stephen, Jim, Ron, Tina, Dan Marcus, Xiaodong

Agenda:

  • News: DCMTK 3.6 was released today
  • http://wiki.na-mic.org/Wiki/index.php/2011_Winter_Project_Week#Projects
  • Command line module logic, supporting multiple argument for images in Slicer3/4
  • Discussion of ITK support for large (greater than 4Gig) image volumes on win64. This will be further investigated at project week. It is only one of several issues to be researched as part of porting slicer3 and slicer4 to win64. Dave Partyka has a project to work on this at project week.
Retrieved from "https://www.na-mic.org/w/index.php?title=Engineering:TCON_2011&oldid=65338"